zmoazeni / csscss

A CSS redundancy analyzer that analyzes redundancy.
http://zmoazeni.github.io/csscss/
MIT License
2.92k stars 151 forks source link

Parser treats import statements as selectors #58

Closed ericpromislow closed 11 years ago

ericpromislow commented 11 years ago

Given this CSS:

@import url("f1/reset.css");
@import url("f1/base.css");

div.app-edit {
    /*border: 2px solid #ddd;*/
    padding: 2px 0px;
    margin: 2px 0px;
    background: url(../img/app-edit.png) no-repeat right top;
}

div.app-ide {
    /*border: 2px solid #ddd;*/
    padding: 2px 0px;
    margin: 2px 0px;
    background: url(../img/app-ide.png) no-repeat right top;
}

div.app-ide-edit {
    /*border: 2px solid #ddd;*/
    padding: 2px 0px;
    margin: 2px 0px;
    background: url(../img/app-ide-edit.png) no-repeat right top;
}

csscss 1.2.0 -v gives this output:

{@import url("f1/reset.css");
@import url("f1/base.css");

div.app-edit}, {div.app-ide} AND {div.app-ide-edit} share 4 rules
  - background-position: right top
  - background-repeat: no-repeat
  - margin: 2px 0px
  - padding: 2px 0px

No parsing errors with --show-parsing-errors

zmoazeni commented 11 years ago

Thanks. Yeah, I need to do something about @import. Going to close this as a dup of #41

zmoazeni commented 11 years ago

@ericpromislow Thanks for the reports. This is fixed in master and will go out in the next release. Likely v1.3.0.