search

zmoazeni / csscss

A CSS redundancy analyzer that analyzes redundancy.
http://zmoazeni.github.io/csscss/
MIT License
2.92k stars 151 forks source link

adding the validation for single special character in attribute #70 #72

Closed joseluistorres closed 11 years ago

joseluistorres commented 11 years ago

Hey @zmoazeni I just pushed a fix for #70 and probably #68. Can you provide some feedback? Thanks

JL

zmoazeni commented 11 years ago

Hrm, I see now. This is also going to fail with content: '}' though. I'll do a little digging, but I should have a quotes rule somewhere in Common.

joseluistorres commented 11 years ago

Yeah I was thinking the same yesterday, I can take a look tonight and implement it. What do you think? @zmoazeni

joseluistorres commented 11 years ago

Hi @zmoazeni no more feedback on this PR?

zmoazeni commented 11 years ago

@joseluistorres Sorry man, I'll try and carve out some time to check into it.

joseluistorres commented 11 years ago

No problem I was just wondering. I love to contribute but I'd rather more learning though

zmoazeni commented 11 years ago

Thanks @joseluistorres - merged into master, and will go out with the next release after v1.3.1.