zmon / Code-for-America-Projects-Hub

Help Brigade members find projects to work on. Promote multi-Brigade collaboration. Onboard new members. Encourage public contribution of ideas. Karma. Visualize scope for Code for America. Provide filtered and sorted card list of projects and ideas for development. The list should be available nation-wide and by city.
http://codeforkc.org/Code-for-America-Projects-Hub/
15 stars 13 forks source link

Develop #102

Closed alfredortega closed 9 years ago

alfredortega commented 9 years ago

Removed idea specific paging, search and getbyid methods in the projectIdeaService and created generic versions of them in the ApiConsumerService

jstirnaman commented 9 years ago

Can you see my notes in 5ebae2d999435817af133377b74d0fd9bc2909aa?

zmon commented 9 years ago

I noticed that in app/idea/ProjectIdeaController.js it return ProjectIdeaService.getIdea(ideaId) so you cannot remove getIdea from app/data/projectIdeaService.js.

Before removing the pageIdeas(pageNumber) you also need to delete line 12
pageIdeas: pageIdeas

I also removed a extra ')' from line 174 in app/data/ApiConsumerServices.js