search

zmon / Code-for-America-Projects-Hub

Help Brigade members find projects to work on. Promote multi-Brigade collaboration. Onboard new members. Encourage public contribution of ideas. Karma. Visualize scope for Code for America. Provide filtered and sorted card list of projects and ideas for development. The list should be available nation-wide and by city.
http://codeforkc.org/Code-for-America-Projects-Hub/
15 stars 13 forks source link

Develop #74

Closed alfredortega closed 9 years ago

alfredortega commented 9 years ago

/views/api/googleDataApiService.js -added ?alt=json to pull data as json vice xml.

/views/project/projectIdeaService.js -simplified paging method -fixed record array declaration.

I'd like to know how these tie into the buttons on the index page so that I can test them. So I can't promise it'll work. If it doesn't the code is pretty close and it's easy to read.

zmon commented 9 years ago

Still getting errors with the same half built screen.

Error: $http is not defined

I think this is happening in views/project/projectIdeaService.js.

Also when I click the "Google Sheet API" The data being returned is not what is in https://docs.google.com/spreadsheets/d/1tnW2fTcPEQG93oebrCfvjZw4Vjtn6vkzvqyovxebKlI/edit?usp=sharing

On Wed, Apr 22, 2015 at 6:14 PM, alfredortega notifications@github.com wrote:

/views/api/googleDataApiService.js -added ?alt=json to pull data as json vice xml.

/views/project/projectIdeaService.js -simplified paging method -fixed record array declaration.

I'd like to know how these tie into the buttons on the index page so that I can test them. So I can't promise it'll work. If it doesn't the code is

pretty close and it's easy to read.

You can view, comment on, or merge this pull request online at:

https://github.com/codeforkansascity/Code-for-America-Projects-Hub/pull/74 Commit Summary

  • Updated to include retrieval of data, find by id, search, and paging.
  • simplified paging method
  • added ?alt=json to pull data as json vice xml.

File Changes

Patch Links:

- https://github.com/codeforkansascity/Code-for-America-Projects-Hub/pull/74.patch

https://github.com/codeforkansascity/Code-for-America-Projects-Hub/pull/74.diff

— Reply to this email directly or view it on GitHub https://github.com/codeforkansascity/Code-for-America-Projects-Hub/pull/74 .

Paul Barham 816-679-8010

zmon commented 9 years ago

Still has issues, is it working on your end?

jstirnaman commented 9 years ago

I can look at this tomorrow or the weekend and get back to @alfredortega. I've been out of pocket recently.

alfredortega commented 9 years ago

Sorry if my comments were ambiguous and I'll try to clarify.

PROJECTS: If the projects are not displaying it is likely due to the "?alt=json" I appended in the "/views/api/googleDataApiService.js" file. There was a comment there stating they wanted to change it to json but needed tabletop. Tabletop isn't needed just the "?alt=json" I can remove that and push tonight.

IDEAS: The spreadsheet would be different because I am pulling from is: https://spreadsheets.google.com/feeds/list/1PGM2P9o0bkJ_xCkoH2ps_Dp5xnBDrPxmIB-jnJWAwhE/1/public/values?alt=json which has the ideas. The one you referenced is the one that holds the projects.

I cannot test displaying ideas on the index page as I don't know how to configure the buttons/directives/??? whatever for the ideas. If someone can she some light on this then I can test it out more and address any issues. I just don't know Angular and how to implement enough to do this.

I will likely be missing this Monday's meeting as I have to go to Texas for work on Tuesday. However I'll have my laptop and access to github and slack so I'll continue working and try to stay connected.