Fix failing tests - Githubissues

zmoog / refurbished

Python packace to access the products information available on the Apple Certified Refurbished section of the Apple Store.

MIT License

11 stars 3 forks source link

Fix failing tests #33

Closed zmoog closed 3 years ago

zmoog commented 3 years ago

Motivation

After the switch from plain lxml to Beautiful Soap 4 the tests started failing because the test pages were loaded as bytes instead of UTF8 strings.

Change description

The test pages are properly decoded from bytes into UTF-8 before being passed to the parser.

Additional Notes

Reviewer checklist

[ ] PR address a single concern.
[ ] PR title and description are properly filled.
[ ] Changes will be merged in master.
[ ] Changes are covered by tests.
[ ] Logging is meaningful in case of troubleshooting.
[ ] History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

AndiCui commented 3 years ago

Take at look at my fork. I got the test working. You just need to decode the bytes to str.

https://github.com/AndiCui/refurbished

AndiCui commented 3 years ago

Just realized that you already fixed that. That was an oversight on my part