search

zmwangx / rust-ffmpeg-sys

FFmpeg bindings for Rust.
113 stars 75 forks source link

FFmpeg 6.1 support #63

Closed AdrianEddy closed 7 months ago

AdrianEddy commented 8 months ago

This PR adds support for FFmpeg 6.1

fcfangcc commented 7 months ago

Have the same needs and hope to merge them as soon as possible @zmwangx

Polochon-street commented 7 months ago

Hi,

Thank you so much for taking care of this :pray:

Would it be possible to also add CI support? Either directly with ffmpeg_version, either doing the hacky method here https://github.com/zmwangx/rust-ffmpeg-sys/commit/7d08e289dbe61f9542bbaaee825aaccebae0f7a0 if it doesn't work

AdrianEddy commented 7 months ago

Sorry, I have no idea how to fix that build, apt keeps giving the error about unmet dependencies, I tried everything and it just won't install ffmpeg. ppa:savoury1/ffmpeg6 says 6.1 available there, but it's not working The docker image is not available yet in jrottenberg/ffmpeg (https://github.com/jrottenberg/ffmpeg/issues/382)

Polochon-street commented 7 months ago

alright, I found a PPA with ffmpeg6.1, we'll use that in the meantime - I cleaned up a bit and will merge https://github.com/zmwangx/rust-ffmpeg-sys/pull/65, it contains the commit you authored, that I slightly tweaked for the CI to work. I'll release it now, and then we can go ahead with rust-ffmpeg itself. Thanks again!