search

zmwangx / rust-ffmpeg-sys

FFmpeg bindings for Rust.
113 stars 75 forks source link

Add support for FFmpeg 7.0 #72

Closed AdrianEddy closed 3 months ago

AdrianEddy commented 3 months ago

This PR adds support for FFmpeg 7.0 and updates dependencies

Polochon-street commented 3 months ago

Hi,

Thanks a lot for taking care of that :) I updated the CI to the "official" ubuntu with ffmpeg 6.1, but I don't think even unofficial builds for 7 are out yet?

I was thinking to wait til the builds are out, and then resurrect https://github.com/zmwangx/rust-ffmpeg-sys/pull/74/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721L42-L77, replacing 6 by 7. What do you think?

AdrianEddy commented 3 months ago

I was thinking to wait til the builds are out, and then resurrect https://github.com/zmwangx/rust-ffmpeg-sys/pull/74/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721L42-L77, replacing 6 by 7. What do you think?

Yes, that's a good way, but even that ppa doesn't have ffmpeg 7.0 yet. I guess I'm ahead of everyone else :) I personally use builds from avbuild

Polochon-street commented 3 months ago

ah, nice! Do you think you could make it work with ffmpeg 7.0? Or we could also wait until that PPA has ffmpeg 7.0 :)

AdrianEddy commented 3 months ago

Ok looks like it now works in the CI with a build from avbuild. Please squash when merging. However, the build from avbuild doesn't seem to include the postproc binary, so I disabled that feature. Not sure how to test that other than building the entire ffmpeg myself, but I guess we can always release a 7.0.1 path if it turns out that the postproc feature is broken (very unlikely though)

Polochon-street commented 3 months ago

thanks for working on that! Let's try it.

Polochon-street commented 3 months ago

merged, and published it on crates.io - now https://github.com/zmwangx/rust-ffmpeg/pull/178 needs to be updated :)