search

zmwangx / rust-ffmpeg-sys

FFmpeg bindings for Rust.
125 stars 86 forks source link

Stack overflow on Windows #9

Open leo60228 opened 3 years ago

leo60228 commented 3 years ago

This is happening in my CI: https://github.com/leo60228/hsmusicifier/runs/1751852366?check_suite_focus=true

I use Linux, so I'm not able to debug this further currently.

leo60228 commented 3 years ago

main in build.rs is using just over the maximum of 2M of stack. I couldn't figure out why this is the case, but adding this to .cargo/config works around the issue:

[target.x86_64-pc-windows-msvc]
rustflags = ["-C", "link-arg=/STACK:4194304"]
AdrianEddy commented 3 years ago

See #12

jwiesler commented 3 years ago

Why is this still not merged? :(

rib commented 3 years ago

I also just got hit by this - it would be great if #12 can be merged

rib commented 3 years ago

Ah, it's looking like maybe the original ffmpeg-sys project that this was forked from might have come back to life, since it looks like there's active development there, including a fix for this issue: https://github.com/meh/rust-ffmpeg-sys/issues/94

jwiesler commented 3 years ago

Hey, I forked the sys crate and the ffmpeg-next crate and merged most of the current merge requests of both crates. If you have no problem with using a non crates.io crate, you can use this one. I will keep merging pull requests because these repositories seem mostly abandonded.