search

zmwangx / rust-ffmpeg

Safe FFmpeg wrapper.
Do What The F*ck You Want To Public License
1.3k stars 203 forks source link

remove filter::Context generic lifetime parameter #194

Closed VincentJousse closed 2 months ago

VincentJousse commented 3 months ago

issue #193

Polochon-street commented 2 months ago

hi! Thanks for your submission :) I just fixed the linting, errors, could you rebase on master to check if the CI's green?

VincentJousse commented 2 months ago

Done ;)

Polochon-street commented 2 months ago

Would you rebase again? There were new clippy errors, seems that rust updates faster than I can fix lints...

VincentJousse commented 2 months ago

@Polochon-street Done again !

Polochon-street commented 2 months ago

thanks!

VincentJousse commented 2 months ago

@Polochon-street just a reminder : this MR breaks the API !! Do you plan any release soon ?

Polochon-street commented 2 months ago

Unfortunately, that crate doesn't follow semver, so I can only release minor versions (otherwise the build script will try and fetch e.g. ffmpegv7.1 as far as I remember). I'll release a new version now :)

Polochon-street commented 2 months ago

it should be released now.