search

zmxv / react-native-sound

React Native module for playing sound clips
MIT License
2.79k stars 748 forks source link

change variable type for key of Dictionary playerPool. #553

Closed huuchi207 closed 5 years ago

huuchi207 commented 5 years ago

update variable type of key of Dictionary playerPool according to commit: Use Double for Player keys to avoid collisions for react-native-windows

paulmelnikow commented 5 years ago

Hi, thanks for this. I'm not sure I understand why the key should be a float. If the key is supposed to uniquely identify the player, it makes more sense for it to be a string or an integer.