search

zmxv / react-native-sound

React Native module for playing sound clips
MIT License
2.79k stars 748 forks source link

Fix getSystemVolume on Android for parity with iOS #569

Closed franck-nadeau closed 5 years ago

franck-nadeau commented 5 years ago

The call back for getSystemVolume is currently being called with (NULL, systemVolume).

This does not match the defined API, nor what iOS does.

callback {?function(systemVolume)}

This will fix this issue: https://github.com/zmxv/react-native-sound/issues/496

paulmelnikow commented 5 years ago

Hi! Thanks so much for this!

Would someone be able to verify this fix? It would expedite getting it merged 😀

paulmelnikow commented 5 years ago

Tested and verified! Thanks so much for the fix!