search

zmxv / react-native-sound

React Native module for playing sound clips
MIT License
2.79k stars 748 forks source link

Added the STREAM_ALARM for android sounds #570

Closed franck-nadeau closed 5 years ago

franck-nadeau commented 5 years ago

Completed for:

https://github.com/zmxv/react-native-sound/issues/227

To Use:

Sound.setCategory('Alarm');
paulmelnikow commented 5 years ago

Hi! Thanks so much for this and your other contribution!

I'd love to get this merged. I've just gotten access and I'll verify it myself when I have time. Meanwhile if anyone else can, that would be great!

By the way, it looks like the change from #569 crept in here. Would you be able to add another commit to reset the unrelated changes?

Thanks 😀

franck-nadeau commented 5 years ago

@paulmelnikow Sorry about the code creep. I fix it in here e624ce8f563e36de05781b4258695bb88740d726

Each PRs are now ready to be merged independently.

Cheers!