search

zmxv / react-native-sound

React Native module for playing sound clips
MIT License
2.79k stars 748 forks source link

React/Core does not exist in react native 0.60 #612

Closed noway closed 4 years ago

noway commented 4 years ago

:beetle: https://github.com/facebook/react-native/issues/25553

:beetle: What is the observed behavior? fails with None of your spec sources contain a spec satisfying the dependency:React/Core.

:beetle: What is the expected behavior? to succeed pod install

:bulb: Possible solution

Change dependency from React/Core to React-Core in podspec

:bulb: Is there a workaround?

grep -rl "s.dependency 'React/Core'" node_modules/ | xargs sed -i '' 's=React/Core=React-Core=g'

:bulb: If the bug is confirmed, would you be willing to create a pull request? sorry no capacity

Is your issue with...

Are you using...

Which versions are you using?

Does the problem occur on...

If your problem is happening on a device, which device?

paulmelnikow commented 4 years ago

Hi! This was fixed in #585 and published in 0.11.0.

noway commented 4 years ago

I looked at https://github.com/zmxv/react-native-sound/releases, and 0.11.0 is marked pre-release, i'm on v0.10.4 which I thought was the latest version. Should the releases be updated, or 0.11.0 is still a release candidate?

paulmelnikow commented 4 years ago

This is all alpha quality and at your own risk, though there's no real difference in the expected quality of 0.11 vs 0.10.

RWOverdijk commented 4 years ago

Hey! Quick question, when will this be a "real" release?

paulmelnikow commented 4 years ago

In the future, please ignore the "prerelease" status in GitHub. This project is not using it to signal anything different about the releases, which are all alpha quality.