zmxv / react-native-sound

React Native module for playing sound clips
MIT License
2.79k stars 748 forks source link

iOS version in XCode project is 9.0 but is 7.0 in podspec #638

Closed flacito closed 4 years ago

flacito commented 4 years ago

:beetle: Description

The IPHONEOS_DEPLOYMENT_TARGET in the XCode project here does not match the iOS version in the podspec file here.

:beetle: What is the observed behavior?

I am getting compiler errors when trying to build with fastlane using Pods. An error like this:

/Users/btwebb/Development/checkoutmyworkout/checkoutmyworkout-mobile/ios/Pods/Bits/Sources/Bits/Data+BytesConvertible.swift:3:1: type 'Data' does not conform to protocol 'BytesInitializable'

:beetle: What is the expected behavior?

A successful compile

:bulb: Does the problem have a test case?

No

:bulb: Possible solution

Change the podspec ios version to 9.0 to match the XCode project setting.

:bulb: Is there a workaround?

target.build_configurations.each do |config|
  if ['RNSound'].include? target.name
    config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '9.0'
  end
end

:bulb: If the bug is confirmed, would you be willing to create a pull request?

Yes.

Is your issue with...

Are you using...

Which versions are you using?

Does the problem occur on...

Neither, compile time problem.

If your problem is happening on a device, which device?