Android - Set Volume Button Controls On Android Audio Stream

zmxv / react-native-sound

React Native module for playing sound clips

MIT License

2.78k stars 748 forks source link

Android - Set Volume Button Controls On Android Audio Stream #693

Closed RadicalRoy closed 3 years ago

RadicalRoy commented 3 years ago

Issue:

Currently changing the audio stream via setCategory does not change the volume control for Android devices. This causes the device's volume buttons to adjust volume for the wrong stream (generally the default ringer).

Fix:

When setting Sound category, also set the volume control so that pressing the volume buttons has the desired effect for the RN app. This is the behavior of apps like Youtube, Pandora, and Spotify to ensure the best user experience when playing audio.

UberMC commented 3 years ago

Thanks this works great. This really deserves to be merged otherwise you can't control the volume of an app. Sometimes sounds are way to loud and unbearable.

RomualdPercereau commented 3 years ago

Already merged in #713