search

zmxv / react-native-sound

React Native module for playing sound clips
MIT License
2.78k stars 748 forks source link

Do not pass redundant callback to RNSound.play function if not required #729

Closed yelnar closed 2 years ago

yelnar commented 3 years ago

These changes help to avoid passing redundant callbacks into RNSound.play function. It can cause an issue when playing short and frequent (e.g. 10 times per second) beep sounds.

Screenshot_20210615-002853

saghul commented 2 years ago

This was a backwards incompatible change, it breaks calling play() without a callback.