search

znamlab / cottage_analysis

Potentially temporary repository to use DLC to track eye position
MIT License
0 stars 0 forks source link

Migrate depth analysis (find depth neurons) #3

Closed yiran25 closed 1 year ago

yiran25 commented 1 year ago

Migrate functions to find depth neurons. Demo scripts are in depth_analysis/demo/depth_preprocess/

ablot commented 1 year ago

@yiran25 I changed the loading of harp_message DI (the part with 8-bits input read as uint8 instead of individual binnary channels). You should double check that it does what you want. I respected the output shape that you had but that drops some data on the other channels (not the frame trigger). Not sure if it was wanted.

znamensk commented 1 year ago

I agree, this is better in imaging/common but could even move to the preprocessing repo.

Good point, dF/F calculation should definitely be in 2p-preprocess

ablot commented 1 year ago

I've lost track of the changes. Shall we merge to dev the current state and keep improving this branch?

yiran25 commented 1 year ago

Hi Antonin, I’ll try to go back to the conversations and resolve some of the earlier comments until early next week, maybe we can merge after that?

Get Outlook for iOShttps://aka.ms/o0ukef

From: Antonin Blot @.> Sent: Thursday, April 13, 2023 3:23:32 PM To: znamlab/cottage_analysis @.> Cc: Yiran He @.>; Mention @.> Subject: Re: [znamlab/cottage_analysis] Migrate depth analysis (find depth neurons) (PR #3)

External Sender: Use caution.

I've lost track of the changes. Shall we merge to dev the current state and keep improving this branch?

— Reply to this email directly, view it on GitHubhttps://github.com/znamlab/cottage_analysis/pull/3#issuecomment-1507062695, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARXNWVOCORNHXV6OQZZLE33XBAD6JANCNFSM6AAAAAAUH7334M. You are receiving this because you were mentioned.Message ID: @.***>

The Francis Crick Institute Limited is a registered charity in England and Wales no. 1140062 and a company registered in England and Wales no. 06885462, with its registered office at 1 Midland Road London NW1 1AT

yiran25 commented 1 year ago

Hi both @ablot @znamensk Shall we merge to dev and work from there as Antonin suggested? I've cleared out some outdated analysis scripts.