search

znc / znc-docker

https://hub.docker.com/_/znc/
51 stars 29 forks source link

Added docker files to build znc for arm arch #3

Closed rubemlrm closed 6 years ago

rubemlrm commented 7 years ago

Added dockerfile for arm architure on slim and full directorys Added run command to make docker-entrypoint.sh as executable so we dont get a permissions denied error

DarthGandalf commented 7 years ago

I don't see any arm in https://github.com/docker-library/official-images/tree/master/library How is this going to work?

rubemlrm commented 7 years ago

@DarthGandalf relative to the last point , i dont really understand your question :/ can you explain better ?

DarthGandalf commented 7 years ago

This image is published on docker as "official" at https://hub.docker.com/_/znc/ Check https://docs.docker.com/docker-hub/official_repos/ for details.

I see ARM mentioned in https://github.com/docker-library/official-images#architectures-other-than-amd64 but I don't see where it refers to Dockerfile.armhf. How this is going to be published on docker hub?

Related: why only arm6, but no arm7 or arm8?

rubemlrm commented 7 years ago

so @DarthGandalf in your opinion wich is the best approach i can take to try port znc to a arm arch and became a official build ?

DarthGandalf commented 7 years ago

@Rubemlrm start with investigating how to make it acceptable as an official build :)

My wishlist:

@yosifkit @tianon can you give any advice about official non-amd64 images?

Thanks!

tianon commented 7 years ago

My advice would be to stay away from multiple Dockerfiles as much as possible -- in our experience converting many of the docker-library official images over to support multiple architectures, a single Dockerfile is much easier to maintain and review, and our tooling is able to adjust the FROM for now while we get manifest lists in place to ease that requirement too (https://github.com/docker-library/official-images/issues/2289).

See https://github.com/docker-library/python/pull/198 (and some of the cross-linked PRs) for our suggested method for adding an appropriate --build value on ./configure, and https://github.com/docker-library/buildpack-deps/pull/59 (and cross-linked PRs) for a way to add an appropriate value for Architectures in the library/znc file.

An easy way to do a rough sanity test for the multiarch Dockerfile is to adjust the FROM to start with i386/ so that you can build the 32bit version (which should build just fine on any modern amd64 CPU) -- that should help catch the types of issues you're likely to run into on other arches like ARM (32 and 64), POWER 8, or System Z. :+1:

DarthGandalf commented 6 years ago

This is fixed, via 7f4f14214b67e540892a281d69f855aefcef35ce and https://github.com/docker-library/official-images/pull/3874