Closed lwpk110 closed 6 months ago
What happened: the code in package controller ,and logging,go file, metastoreLog4j method,the code below miss a dot:
controller
logging,go
metastoreLog4j
func (r *MetastoreLoggingRecociler) metastoreLog4j(loggingConfig *hivev1alpha1.LoggingConfigSpec) string { properties := make(map[string]string) if loggingConfig.Loggers != nil { for k, level := range loggingConfig.Loggers { if level != nil { v := *level properties["logger."+k+"level"] = v.Level } } }
the bug row is properties["logger."+k+"level"] = v.Level , there is a dot(.) missing before the level word
properties["logger."+k+"level"] = v.Level
.
level
What you expected to happen:
correct code should be properties["logger."+k+".level"] = v.Level
properties["logger."+k+".level"] = v.Level
@lwpk110 ok i will fix the follow code:
https://github.com/zncdata-labs/hive-operator/blob/cee7d4eafd53498334c836b34da0abcac982c2ed/internal/controller/logging.go#L206-L209
closed by : https://github.com/zncdata-labs/hive-operator/pull/51
What happened: the code in package
controller
,andlogging,go
file,metastoreLog4j
method,the code below miss a dot:the bug row is
properties["logger."+k+"level"] = v.Level
, there is a dot(.
) missing before thelevel
wordWhat you expected to happen:
correct code should be
properties["logger."+k+".level"] = v.Level