Factorize checkfile to cmdutils.js and test it.

znerol / node-delta

Delta.js - A JavaScript diff and patch engine for DOM trees

http://znerol.github.com/node-delta/

MIT License

47 stars 11 forks source link

Closed blambeau closed 8 years ago

blambeau commented 8 years ago

Hey @znerol,

This pull request factorizes checkfile to reuse & test it.

For the record, the binaries in bin are currently broken on my node.js installation, for two reasons at least:

path.existsSync needs to be replaced by fs.existsSync (done in this commit)
process.ARGV needs to be replaced by process.argv (is that an expected change in the node.js world?)

I think that factorizing parts and testing them is probably the way to go, right?

znerol commented 8 years ago

Thanks a lot. Truly makes a lot of sense.

znerol commented 8 years ago

Also pushed a fix for the process.argv problem.

znerol commented 8 years ago

Oh, just noticed that yield is a reserved word. Replaced it with invoked in the test (2b171a9).

blambeau commented 8 years ago

Sorry about that, did not know yield was reserved in javascript/node.