znicholls / CMIP6-json-data-citation-generator

Simple scripts to automatically generate json data citations for CMIP6 data files
https://cmip6-json-data-citation-generator.readthedocs.io/en/latest/
BSD 2-Clause "Simplified" License
1 stars 2 forks source link

Testing upload #2

Closed znicholls closed 6 years ago

znicholls commented 6 years ago

@MartinaSt Do you want to include uploading in this repository? If yes, is there a way we can test that the upload works? The options I'm thinking of are:

MartinaSt commented 6 years ago

@znicholls Good question...

Do you want to include uploading in this repository? If yes, is there a way we can test that the upload works?

It is easy to update/overwrite but not easy to delete/ignore. Because of the authentication fakes would either need to be introduced for every citation manager (currently 50) or everybody uses a common fake identity and works on the same fake data. I don't think this is a good idea, might create confusion. Checking the json is only done at the start in the sense that the file is a valid json. Checking the content would be nice but there is currently no capacity to do it, not in the time frame we are talking about.

Thus, I would not do an automated upload of the created jsons, at least not by default. Users should try a single json file upload before doing multiple uploads automatically. What about implementing the upload part but deactivate it by default? Or do you have any better suggestion?

znicholls commented 6 years ago

What about implementing the upload part but deactivate it by default?

I think this is the right approach.

The last step of all of this can be making sure that the files I produce can actually be uploaded, we can talk about the best way for me to do that later.

znicholls commented 6 years ago

Closed by #4