search

znjameswu / flutter_math

Math rendering and editing in pure Flutter.
https://znjameswu.github.io/flutter_math_demo/
Apache License 2.0
123 stars 52 forks source link

Closes #37 Hot fix for Flutter 2.0 stable version #39

Closed walsha2 closed 3 years ago

walsha2 commented 3 years ago

@znjameswu this resolves #37 to fix the currently broken version of this package on the latest Flutter stable. Can you please review and accept pull request.

beingentangled commented 3 years ago

is this working?

walsha2 commented 3 years ago

is this working?

@beingentangled I have tried to contact @znjameswu but still have not heard back. We need someone with write access to the repo to merge this in. The pull request should resolve the build error, yes.

I was initially using CaTeX and then they posted:

We worked together with flutter_math to make that package have all the necessary functionality and you should be able to use it in place of CaTeX for the while being.

So for that reason, I switched to flutter_math thinking it would be actively maintained. We need some more maintainers. @znjameswu please consider giving other users write privileges to help with the development load. Since CaTeX is not going to be actively maintained, this is an important package that needs to be up to date with latest dart/flutter changes.

We don't need yet another TeX fork for flutter use so it would be nice with the community coalesced on a single package. Pub.dev packages are already very fragmented and there is lots of duplicate work.

beingentangled commented 3 years ago

@walsha2 Hope, I can use your repo for getting the fix until this request is merged.

beingentangled commented 3 years ago

@walsha2 after using your version for the fix I'm getting the following error: Because every version of flutter_math from git depends on provider ^5.0.0-nullsafety.2 and depends on provider ^4.3.2+2, flutter_math from git is forbidden. So, because depends on flutter_math from git, version solving failed. pub get failed (1; So, because *** depends on flutter_math from git, version solving failed.)

walsha2 commented 3 years ago

@beingentangled If you need the null-safety version you should probably use the following repo as discussed by @creativecreatorormaybenot

https://github.com/simpleclub-extended/flutter_math_fork

If you need the non null-safety version which resolves the dependency issue you see above, you will need the following:

  flutter_math:
    git:
      url: git://github.com/walsha2/flutter_math
      ref: 37-flutter-2-hot-fix-0.2.x
walsha2 commented 3 years ago

Closing this PR in favor of https://github.com/simpleclub-extended/flutter_math_fork for the null-safety version