znjameswu / flutter_math

Math rendering and editing in pure Flutter.
https://znjameswu.github.io/flutter_math_demo/
Apache License 2.0
123 stars 52 forks source link

Merge flutter_math_fork (containing Flutter 2.0 compatibility changes) #43

Closed creativecreatorormaybenot closed 2 years ago

creativecreatorormaybenot commented 3 years ago

As flutter_math has not been maintained for the past few months, we decided to fork it into flutter_math_fork in order to publish it as a compatible Pub package.

The Pub dependency is the following:

flutter_math_fork: ^3.0.0

We do not intend to maintain this fork in the long-term. Instead, we would like to merge this effort back into the original repo, which is why this branch will be kept in sync.

Skyost commented 3 years ago

Great initiative !

walsha2 commented 3 years ago

@creativecreatorormaybenot - thanks for the information. I have a question about long term though and maybe you might have some insight from a CaTeX perspective.

Initially I was much more drawn to CaTeX because it seemed to be developed by a team and not an individual. I am always hesitant to use packages with only one maintainer because of issues like this. On the CaTeX page it states:

We worked together with flutter_math to make that package have all the necessary functionality and you should be able to use it in place of CaTeX for the while being.

Is this still the stance? We, the community, really do need a well maintained Flutter TeX effort. I would be more than happy to support but I have no idea where those efforts are being centralized. flutter_math? CaTeX? flutter_math_fork?

Any insight would be appreciated!

creativecreatorormaybenot commented 3 years ago

@walsha2 Hi, glad you are interested :)

I understand your concerns and I agree with you that we need something like KaTeX (well maintained) in Flutter - that was the idea with CaTeX.

To be frank, we did not have the resources to develop CaTeX at the time and @znjameswu did such an amazing job on flutter_math afterwards that we figured we would go with it.

The vision is definitely still to make CaTeX a reality (beyond prototype status) and I think there is a lot to be learned from flutter_math. Additionally, we are planning to expand on the ecosystem, which you will be seeing very soon (I guess you can follow me if you are curious 😄). It will be clear that it would make sense for simpleclub to dive deeper into the topic, but it really depends on the path of the simpleclub product.

If you would like to collaborate, let me know :)

codecov-commenter commented 3 years ago

Codecov Report

Merging #43 (cee522a) into master (fcc2389) will decrease coverage by 1.47%. The diff coverage is 84.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   77.09%   75.61%   -1.48%     
==========================================
  Files         136      134       -2     
  Lines        6504     6545      +41     
==========================================
- Hits         5014     4949      -65     
- Misses       1490     1596     +106     
Impacted Files Coverage Δ
lib/src/ast/nodes/enclosure.dart 66.66% <0.00%> (-2.65%) :arrow_down:
lib/src/ast/nodes/space.dart 93.93% <ø> (ø)
lib/src/ast/options.dart 79.82% <ø> (ø)
lib/src/ast/tex_break.dart 100.00% <ø> (ø)
lib/src/parser/tex/macro_expander.dart 80.76% <ø> (ø)
lib/src/parser/tex/macros.dart 89.91% <0.00%> (+0.25%) :arrow_up:
lib/src/render/layout/layout_builder_baseline.dart 48.48% <0.00%> (-38.62%) :arrow_down:
lib/src/render/layout/shift_baseline.dart 54.83% <0.00%> (-3.79%) :arrow_down:
lib/src/widgets/math.dart 84.00% <ø> (+2.00%) :arrow_up:
lib/src/widgets/selection/overlay.dart 90.17% <ø> (+0.89%) :arrow_up:
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fcc2389...cee522a. Read the comment docs.

creativecreatorormaybenot commented 2 years ago

I am closing this PR for now as the flutter_math repo is not being maintained.