search

znjameswu / flutter_math

Math rendering and editing in pure Flutter.
https://znjameswu.github.io/flutter_math_demo/
Apache License 2.0
123 stars 52 forks source link

Remove need for fonts in Pubspec #6

Closed creativecreatorormaybenot closed 4 years ago

creativecreatorormaybenot commented 4 years ago

The previous way was slightly strange.

You can specify the package in the text style, which removes the need for the asset declaration for users.

codecov-commenter commented 4 years ago

Codecov Report

Merging #6 into master will increase coverage by 0.55%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   74.62%   75.17%   +0.55%     
==========================================
  Files          99       99              
  Lines        4689     4689              
==========================================
+ Hits         3499     3525      +26     
+ Misses       1190     1164      -26
Impacted Files Coverage Δ
lib/src/render/symbols/make_atom.dart 71.05% <100.00%> (ø)
lib/src/render/svg/stretchy.dart 97.67% <0.00%> (+4.65%) :arrow_up:
lib/src/render/layout/line.dart 82.68% <0.00%> (+10.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7bd8347...ea9ddf0. Read the comment docs.

creativecreatorormaybenot commented 4 years ago

@znjameswu Why is CI failing?

znjameswu commented 4 years ago

CI failure is probably because the font loader settings are not changed during the testing. I'll be investigating.

Also thank you for this nice technique. I did not know I can specify font like this.