Bug: ckeditor plugin codemirror missing since 6.0.40

meisterheister commented 2 years ago

Environment

OS: unkown
Browser: any
Znuny version: 6.0.40 / 6.0.31

Expected behaviour

The XSLT editor should be shown when editing webservices

Actual behaviour

The editor is not loaded due to a missing plugin: "CodeMirror"

How to reproduce

Steps to reproduce the behaviour:

Open Webservice
Edit XSLT

Additional information

Now lots of additional plugins have been packaged with the new release (from 64 to 124!) but one has been removed 'codemirror'.

Is there any reason why this happened?

It seems to me that you moved to integrate not only specific but all plugins from ckeditor4 pre-release repository plus some extra (contextmenu_linkopen, exportpdf, scayt, splitquote, wsc). No ckeditor version before included 'codemirror' plugin by default so it seems it has been added before as well. BTW: Release repository is ckeditor/ckeditor4-releases with less plugins for 4.17.1.

Since the last update to znuny 6.0.40 the ckeditor was also updated from reportedly 4.16.0 to 4.17.1. See commit: Updated CKEditor from version 4.16.0 to 4.17.1.

Could you please integrate the 'codemirror' plugin again?

dennykorsukewitz commented 2 years ago

@hanneshal Thank you for using the github issue template!

hanneshal commented 2 years ago

Hi @meisterheister

thanks for reporting this. We are already working on this (reference internal issue#217).

Is there any reason why this happened?

Yes. Bugs happen. We are on it.

Just a note: please don't delete the bug template when you create issues. It is there for a reason ;)

meisterheister commented 2 years ago

@hanneshal many thanks for the quick update! I did not delete the bug template just clicked "new issue". This seems to be a github bug since when you click before being logged in you will not be presented with any templates.