Fixed Selenium tests. - Githubissues

znuny / Znuny

Znuny/Znuny LTS is a fork of the ((OTRS)) Community Edition, one of the most flexible web-based ticketing systems used for Customer Service, Help Desk, IT Service Management.

https://www.znuny.org

GNU General Public License v3.0

381 stars 89 forks source link

Fixed Selenium tests. #288

Closed tipue-dev closed 2 years ago

tipue-dev commented 2 years ago

Proposed change

Remove some old test cases that are no longer valid

'1 - 💎 code quality'

Breaking change

Additional information

This PR is related to PR: https://github.com/znuny/Znuny/pull/283
- [x] The code change is tested and works locally.(❗)
- [x] There is no commented out code in this PR.(❕)
- [x] You improved or added new unit tests.(❕)
- [ ] Local ZnunyCodePolicy run passes successfully.(❕)
- [ ] Local unit tests pass.(❕)
- [x] GitHub workflow ZnunyCodePolicy passes.(❗)
- [x] GitHub workflow unit tests pass.(❗)

dennykorsukewitz commented 2 years ago

Hi @tipue-dev,

please sync this branch with latest commits, to get the new selenium workflow.

👍🏼

dennykorsukewitz commented 2 years ago

Hi @tipue-dev

I also recovered an internal branch where I already fixed some Selenium tests. It looks like your fixes and mine are duplicating each other. I would suggest that I merge the current PR first and then we see what of my fixes might still solve bugs.

Currently only Agent and Customer seem to be a problem.

tipue-dev commented 2 years ago

Hey @dennykorsukewitz

/opt/otrs/scripts/test/Selenium/Customer/Ajax/ErrorHandling.t (Customer) gives an error now, while nothing changed and before that scripts/test/Selenium/Agent/Ajax/ErrorHandling.t (Agent) threw an error but works now. locally it works every time. no Idea what that is.

The only other error is the one with the Appointments, where i made a separate PR https://github.com/znuny/Znuny/pull/292.