znuny / Znuny

Znuny/Znuny LTS is a fork of the ((OTRS)) Community Edition, one of the most flexible web-based ticketing systems used for Customer Service, Help Desk, IT Service Management.
https://www.znuny.org
GNU General Public License v3.0
355 stars 85 forks source link

Fixed "NoPermission" screen to use "CustomerNoPermission" for ACL checking. #333

Closed paulfolkers closed 1 year ago

paulfolkers commented 1 year ago

Proposed change

With "NoPermission" function, the customer is redirected to the agent screen, even though the URL is still the customer backend: https://my-znuny-host/otrs/customer.pl?Action=CustomerTicketZoom;TicketNumber=2022122196000021

The resulting permission error looks like this:

Xnip2023-01-17_15-43-49

In other places within this module, there is already the right function "CustomerNoPermission" used.

The updated code results in a proper error message:

Xnip2023-01-17_15-52-09

Steps to reproduce

To reproduce this error, simply configure an ACL that filters for "Properties" -> "CustomerUser" -> "UserLogin" -> [any customer user] and next configure a "PossibleNot" -> "Action" -> "CustomerTicketZoom". This will show the agent error message from the first screenshot when you are opening the CustomerTicketZoom for any ticket.

Type of change

1 - šŸž bug šŸž

Checklist