znuny / Znuny

Znuny/Znuny LTS is a fork of the ((OTRS)) Community Edition, one of the most flexible web-based ticketing systems used for Customer Service, Help Desk, IT Service Management.
https://www.znuny.org
GNU General Public License v3.0
355 stars 85 forks source link

Added missing TicketID in ArticleList. #346

Closed JannisKleinrensing closed 7 months ago

JannisKleinrensing commented 1 year ago

Proposed change

There is a error when creating a "Incoming Phone Call"-Article if there is no customeruser set in the ticket. The sender of the article is 'Znuny System' instead of the customer.

When there is no customeruser set Znuny tries to get the sender from the returned array of the ArticleList function. This always fails because no TicketID parameter is passed to the function.

How to reproduce the error: Create a ticket by just adding a email address instead of a customeruser as the customer of the ticket. After the ticket has been created, add an article to it by using the AgentTicketPhoneInbound action. In addition there will be the following error in the log:

 Message: Need TicketID!

 RemoteAddress: 10.0.2.2
 RequestURI: /ZnunyUpdates/index.pl

 Traceback (2621):
   Module: Kernel::System::Ticket::Article::ArticleList Line: 224
   Module: Kernel::Modules::AgentTicketPhoneCommon::Run Line: 871
   Module: Kernel::System::Web::InterfaceAgent::Run Line: 1144
   Module: /opt/frameworks/ZnunyUpdates/bin/cgi-bin/index.pl Line: 39

1 - 🐞 bug 🐞

Additional information

Before: BeforeBugFix

After: AfterBugFix

Checklist

dignin commented 7 months ago

@NiklasSchmitt This resolves the logging issue, in my opinion.