znuny / Znuny

Znuny/Znuny LTS is a fork of the ((OTRS)) Community Edition, one of the most flexible web-based ticketing systems used for Customer Service, Help Desk, IT Service Management.
https://www.znuny.org
GNU General Public License v3.0
355 stars 85 forks source link

Remove unnecessary log message. (#348) #350

Closed markusraulf closed 1 year ago

markusraulf commented 1 year ago

Proposed change

Removes error message in case the SystemAddressLookup has no results. But keeps the error message for calling the function with insufficient parameters.

Type of change

Breaking change

Additional information

This function is only used in Email.pm line 604 and SystemAddress.t. AgentTicketEmail.pm and AgentTicketPhone.pm have their own SystemAddressLookup implementation. Maybe they can be refactored to use the SystemAddressLookup() function.

Checklist

NiklasSchmitt commented 1 year ago

Hi @markusraulf,

thank you very much for your merge-request and your participation. We have already removed the log-message with commit https://github.com/znuny/Znuny/commit/1275d2b8f8e9ec1775fa801b03505febde07f587 (internal issue 495)

Best regards, Niklas