Znuny/Znuny LTS is a fork of the ((OTRS)) Community Edition, one of the most flexible web-based ticketing systems used for Customer Service, Help Desk, IT Service Management.
This mod fixes several problems in filename cleanup
and attachment handling:
filename celanup logice was messy and contained
obsolete UTF-* filtering,
if two different filenames were cleaned up to the same
filename, uploading it failed (with WebUploadCacheModule
= Kernel::System::Web::UploadCache::FS try to upload files
test.txt and .test.txt to the same article using agent
web panel - you'll see broken attachment list,
mapping attached message/rfc822 message subject to filename
was not optimal and didn't handle empty subjects well (attachment
will be named "eml" not similar to "file-N.eml" as it should),
Ajax UI did not support filename cleanups at server side
on attachment upload,
a few uninitialized variables generated errors in apache
error.log,
Note:
This mod does not resolve problems with WebUploadCacheModule
= Kernel::System::Web::UploadCache::DB because it'll require
DB schema change (no column for original filename in SQL
web_upload_cache table available now); uploading
long filenames (i.e 0123456ąćę111110123456ąćę0123456ąćę01234
56ąćę0123456ąćę0123456ąćę0123456ąćę0123456ąćę0123456ąćę01234
56ąćę0123456ąćę0123456ąćę0123456ąćę0123456ąćę0123456ąćę01234
56ąćę0123456ąćę0123456ąćę0123456ąćę0123456ąćę0123456ąćę01234
56ąćę0123456ąćę0123456ąćę005.txt) will generate broken
attachment list and sending such article will generate ugly
trimmed attachement filename.
Proposed change
This mod fixes several problems in filename cleanup and attachment handling:
filename celanup logice was messy and contained obsolete UTF-* filtering,
if two different filenames were cleaned up to the same filename, uploading it failed (with WebUploadCacheModule = Kernel::System::Web::UploadCache::FS try to upload files test.txt and .test.txt to the same article using agent web panel - you'll see broken attachment list,
mapping attached message/rfc822 message subject to filename was not optimal and didn't handle empty subjects well (attachment will be named "eml" not similar to "file-N.eml" as it should),
Ajax UI did not support filename cleanups at server side on attachment upload,
a few uninitialized variables generated errors in apache error.log,
Note: This mod does not resolve problems with WebUploadCacheModule = Kernel::System::Web::UploadCache::DB because it'll require DB schema change (no column for original filename in SQL web_upload_cache table available now); uploading long filenames (i.e 0123456ąćę111110123456ąćę0123456ąćę01234 56ąćę0123456ąćę0123456ąćę0123456ąćę0123456ąćę0123456ąćę01234 56ąćę0123456ąćę0123456ąćę0123456ąćę0123456ąćę0123456ąćę01234 56ąćę0123456ąćę0123456ąćę0123456ąćę0123456ąćę0123456ąćę01234 56ąćę0123456ąćę0123456ąćę005.txt) will generate broken attachment list and sending such article will generate ugly trimmed attachement filename.
Additional information
Replaces: https://github.com/znuny/Znuny/pull/77 Related: https://github.com/OTRS/otrs/pull/1181 Related: https://github.com/OTRS/otrs/pull/1959 Author-Change-Id: IB#1016067
Type of change
Checklist