Closed pboguslawski closed 3 months ago
@pboguslawski We really like this PR but require some changes:
1.) Please also add two settings for the apple-touch-icons (AgentAppleTouchIcon, CustomerAppleTouchIcon) to cover both types of icons.
2.) It would be great to have a simplified template and instead of
[% IF Config("AgentShortcutIcon") -%]
<link rel="shortcut icon" href="[% Config("AgentShortcutIcon") %]" type="image/ico" />
[% ELSE -%]
<link rel="shortcut icon" href="[% Config("Frontend::ImagePath") %]icons/product.ico" type="image/ico" />
[% END -%]
a small change like
<link rel="shortcut icon" href="[% Config("Frontend::ImagePath") %][% Config("AgentShortcutIcon") %]" type="image/ico" />
would be more appropriate. Since these icons should be located in the document root of the web server this simplifies the change. Thank you.
a small change like
<link rel="shortcut icon" href="[% Config("Frontend::ImagePath") %][% Config("AgentShortcutIcon") %]" type="image/ico" />
would be more appropriate. Since these icons should be located in the document root of the web server this simplifies the change.
Frontend::ImagePath
points to agent panel skin area so it's better not to use it for CustomerShortcutIcon
nor AgentShortcutIcon
which makes it possible to use any web root relative path not just Frontend::ImagePath
or web document root (which is not required).
Please let us know if you accept this PR if AgentAppleTouchIcon
and CustomerAppleTouchIcon
will be added same way (without forcing Frontend::ImagePath
nor web root as it is not required either).
shortcut icon and Apple touch icon will be configurable within Znuny 7.1.1, see commit https://github.com/znuny/Znuny/commit/659192f8fb7afdba7796912029c9e4bf12341368. I'll close this pull request.
Proposed change
This mod introduces two new SysConfig parameters
that allow one to specify shortcut icons to use in Znuny agent and customer panel.
Type of change
Additional information
Related: https://github.com/OTRS/otrs/pull/1426 Author-Change-Id: IB#1046319
Checklist