Configurable shortcut icon

znuny / Znuny

Znuny/Znuny LTS is a fork of the ((OTRS)) Community Edition, one of the most flexible web-based ticketing systems used for Customer Service, Help Desk, IT Service Management.

https://www.znuny.org

GNU General Public License v3.0

343 stars 83 forks source link

Configurable shortcut icon #376

Closed pboguslawski closed 3 months ago

pboguslawski commented 1 year ago

Proposed change

This mod introduces two new SysConfig parameters

AgentShortcutIcon
CustomerShortcutIcon

that allow one to specify shortcut icons to use in Znuny agent and customer panel.

Type of change

'1 - 🚀 feature' - New feature (which adds functionality to an existing integration)

Additional information

Related: https://github.com/OTRS/otrs/pull/1426 Author-Change-Id: IB#1046319

Checklist

[x] The code change is tested and works locally.(❗)
[x] There is no commented out code in this PR.(❕)
[x] You improved or added new unit tests.(❕)
[x] Local ZnunyCodePolicy passed.(❕)
[x] Local UnitTests / Selenium passed.(❕)
[ ] GitHub workflow CI (UnitTests / Selenium) passed.(❗)

rkaldung commented 1 year ago

@pboguslawski We really like this PR but require some changes:

1.) Please also add two settings for the apple-touch-icons (AgentAppleTouchIcon, CustomerAppleTouchIcon) to cover both types of icons.

2.) It would be great to have a simplified template and instead of

[% IF Config("AgentShortcutIcon") -%]
    <link rel="shortcut icon" href="[% Config("AgentShortcutIcon") %]" type="image/ico" />
[% ELSE -%]
    <link rel="shortcut icon" href="[% Config("Frontend::ImagePath") %]icons/product.ico" type="image/ico" />
[% END -%]

a small change like

<link rel="shortcut icon" href="[% Config("Frontend::ImagePath") %][% Config("AgentShortcutIcon") %]" type="image/ico" />

would be more appropriate. Since these icons should be located in the document root of the web server this simplifies the change. Thank you.

pboguslawski commented 11 months ago

a small change like
<link rel="shortcut icon" href="[% Config("Frontend::ImagePath") %][% Config("AgentShortcutIcon") %]" type="image/ico" />
would be more appropriate. Since these icons should be located in the document root of the web server this simplifies the change.

Frontend::ImagePath points to agent panel skin area so it's better not to use it for CustomerShortcutIcon nor AgentShortcutIcon which makes it possible to use any web root relative path not just Frontend::ImagePath or web document root (which is not required).

Please let us know if you accept this PR if AgentAppleTouchIcon and CustomerAppleTouchIcon will be added same way (without forcing Frontend::ImagePath nor web root as it is not required either).

NiklasSchmitt commented 3 months ago

shortcut icon and Apple touch icon will be configurable within Znuny 7.1.1, see commit https://github.com/znuny/Znuny/commit/659192f8fb7afdba7796912029c9e4bf12341368. I'll close this pull request.