search

znuny / Znuny

Znuny/Znuny LTS is a fork of the ((OTRS)) Community Edition, one of the most flexible web-based ticketing systems used for Customer Service, Help Desk, IT Service Management.
https://www.znuny.org
GNU General Public License v3.0
343 stars 83 forks source link

Did the value for $Method get mixed up in Auth::DB? #379

Closed kjarex closed 5 months ago

kjarex commented 1 year ago

I assume $Method should be set to 'sha512' in this line: https://github.com/znuny/Znuny/blob/9cadca40a1472d3e55544bedfa40b6866da3b9e1/Kernel/System/Auth/DB.pm#L170

rkaldung commented 1 year ago

@kjarex You're right, this looks odd. Maybe it's a ten year old, undetected bug. We'll dig into it

eyazi commented 1 year ago

At first glance, this only looks like a typo for the debugging.

https://github.com/znuny/Znuny/blob/9cadca40a1472d3e55544bedfa40b6866da3b9e1/Kernel/System/Auth/DB.pm#L166

sha512 is still getting used for hashing.

NiklasSchmitt commented 6 months ago

internal issue 827

NiklasSchmitt commented 5 months ago

Fixed with commits https://github.com/znuny/Znuny/commit/6b0d53ebfdd8df37ee69752b0a3bc9a598261e0c & https://github.com/znuny/Znuny/commit/fb33cbb32ea62588fbfc7b02f823800f53d5c25c.