znuny / Znuny

Znuny/Znuny LTS is a fork of the ((OTRS)) Community Edition, one of the most flexible web-based ticketing systems used for Customer Service, Help Desk, IT Service Management.
https://www.znuny.org
GNU General Public License v3.0
343 stars 83 forks source link

Redundant article search index rebuilding fixed #395

Open pboguslawski opened 1 year ago

pboguslawski commented 1 year ago

Proposed change

Article search index is rebuild twice:

(1) in ArticleCreate (ArticleSearchIndexBuild called)

and

(2) by FulltextIndexRebuildWorker.pm task called from otrs.Daemon (because articles are created in article table with default value in search_index_needs_rebuild column which is 1).

This is waste of resouces and may cause unnecessarry data fragmentation in search index backends.

This mod resolves this issue by unflagging article for search index rebuilding after successfull index rebuild.

To be considered for future versions (not included in this mod): change article.search_index_needs_rebuild default value in DB schema to 0 to avoid possible races with otrs.Daemon trying to update article search index just after insert to article table in ArticleCreate and before ArticleCreate calls ArticleSearchIndexBuild.

Type of change

Additional information

Replaces: https://github.com/znuny/Znuny/pull/62 Author-Change-Id: IB#1108194

Checklist