znuny / Znuny

Znuny/Znuny LTS is a fork of the ((OTRS)) Community Edition, one of the most flexible web-based ticketing systems used for Customer Service, Help Desk, IT Service Management.
https://www.znuny.org
GNU General Public License v3.0
343 stars 83 forks source link

Notification templates initialization fix #397

Closed pboguslawski closed 6 months ago

pboguslawski commented 1 year ago

Proposed change

Two youngest notifications ID 15 and ID 16 were introduced with e-mail template set to Default which is inconsistent with other e-mail notification templates in system. This mod fixes it (both notifications will initialize template same way as other notifications).

Type of change

Additional information

Replaces: https://github.com/znuny/Znuny/pull/100 Author-Change-Id: IB#1109073

Checklist

NiklasSchmitt commented 6 months ago

You are right. Set TransportEmailTemplate to Default via the initial data insert only for the two last added notification templates (id 15 &16) is not needed.

The Default value of TransportEmailTemplate is already set to Default (see https://github.com/znuny/Znuny/blob/dev/Kernel/System/Ticket/Event/NotificationEvent/Transport/Email.pm#L434) and will be stored in database while adding/editing a notification.