search

znuny / Znuny

Znuny/Znuny LTS is a fork of the ((OTRS)) Community Edition, one of the most flexible web-based ticketing systems used for Customer Service, Help Desk, IT Service Management.
https://www.znuny.org
GNU General Public License v3.0
335 stars 82 forks source link

Bug - Missing group timeaccounting_webservice created on upgrade to 6.1 #428

Closed pboguslawski closed 6 months ago

pboguslawski commented 1 year ago

Environment

Expected behaviour

No unnecessary groups created on upgrade. Same upstream groups should exist after upgrade to 6.5 and fresh 6.5 install.

Actual behaviour

When upgrading from 6.0 to 6.5 one need to upgrade to 6.1 first. 6.1 upgrade script creates timeaccounting_webservice group. Group looks like not required for systems that do not use timeaccounting webservice so only _MigrateGroupNames should be called there without _CreateMissingGroups probably.

After upgrading 6.0->6.1->6.2->6.3->6.4->6.5 group timeaccounting_webservice is present (with empty description). After fresh 6.5 install no such group is present in system.

How to reproduce

Steps to reproduce the behavior:

Upgrade from 6.0 to 6.1. Install fresh 6.5.

rkaldung commented 1 year ago

@pboguslawski This group is necessary since it's required to permit access to the ticket operation TimeAccountingGet.

To fix this it's required to have this group.

pboguslawski commented 1 year ago

To fix this it's required to have this group.

Forcing to create separate, hard-coded group for one specific and optional (if understood correctly) web operation sounds bad.

If separate privilege is necessary for this op, consider rather introducing sysconfig parameter with group name for it, empty by default; then when admin wants to grant access to this op, should set chosen group (creating it manually if necessary).

rkaldung commented 6 months ago

Already fixed for Znuny LTS 6.5 and Znuny 7.0.