Fixed Popup profile positioning.

[pboguslawski]

Proposed change

Popup profile top, left, width and height parameter values should be interpreted by JS as numbers not strings (left popup value was concatenation not sum of window.screen.left and PopupProfiles[PopupProfile].Left and was producing wrong popup positioning).

Popup positioning on dual monitor setup in Firefox was broken because screenX returns position on spanned screen not current screen and according to

https://developer.mozilla.org/en-US/docs/Web/API/Screen/top https://developer.mozilla.org/en-US/docs/Web/API/Screen/left

window.screen.top and window.screen.left are non-standard/obsolete and should be avoided.

This fixes these positioning problems.

Type of change

• '1 - 🐞 bug 🐞' - Bugfix (non-breaking change which fixes an issue)

Additional information

Fixes: a20eddf94b64dc30ecf92910fb7bc4b16c4cf612 Related: https://github.com/znuny/Znuny/issues/432 Author-Change-Id: IB#1133822

Checklist

• [x] The code change is tested and works locally.(❗)
• [x] There is no commented out code in this PR.(❕)
• [ ] You improved or added new unit tests.(❕)
• [x] Local ZnunyCodePolicy passed.(❕)
• [x] Local UnitTests / Selenium passed.(❕)
• [ ] GitHub workflow CI (UnitTests / Selenium) passed.(❗)

[dennykorsukewitz]

Hi @pboguslawski

unfortunately I can't merge this PR because the source (6.5) doesn't match the target (7.0) version. I will apply your changes by hand. https://github.com/znuny/Znuny/commit/02faa158e63fe305d9c264aa1c29c4e71d572008

Thank you very much. 🚀