znuny / Znuny

Znuny/Znuny LTS is a fork of the ((OTRS)) Community Edition, one of the most flexible web-based ticketing systems used for Customer Service, Help Desk, IT Service Management.
https://www.znuny.org
GNU General Public License v3.0
335 stars 82 forks source link

Use fullname for user mention label. #436

Closed tgurr closed 1 year ago

tgurr commented 1 year ago

Proposed change

Change the displayed username to fullname to be more useful and to bring it in line with what is shown in the mentions widget.

For example in our company the username can be quite meaningless/cryptic so if you mention multiple persons like:

@user1 check network @user2 check firewall

it would end up being problematic to identify which person is actually meant as it would result in something like:

image

While with changing it to fullname it'll read:

image

which also brings it in line with the mentions shown in the mentions widget where fullname appears to be already used:

image

Breaking change

Additional information

Checklist

tgurr commented 1 year ago

Sadly it looks liks just changing the template variable isn't enough here as after changing it neither a mentioned notification mail has been sent nor the timestampt with the latest mentioning on the respective ticket on the mentions dashboad widget has been updated. Still would love to see this being changed and brought in line with the mentions widget on the right side of the ticket but as it appears to be not that easy I might not be able to provide an updated complete working PR.

dignin commented 1 year ago

Please create an issue in the feature-request repository. Since this change is incomplete, I will close it. If you manage to make all the necessary changes, please feel free to resubmit.