znuny / Znuny

Znuny/Znuny LTS is a fork of the ((OTRS)) Community Edition, one of the most flexible web-based ticketing systems used for Customer Service, Help Desk, IT Service Management.
https://www.znuny.org
GNU General Public License v3.0
333 stars 82 forks source link

Fixed Selenium test AdminCustomerUserService.t #482

Closed tipue-dev closed 10 months ago

tipue-dev commented 10 months ago

Proposed change

The test (Selenium/Agent/Admin/AdminCustomerUserService.t) failed because the input with the value that equals the service id isn't clickable.

    /opt/znuny/scripts/test/Selenium/Agent/Admin/AdminCustomerUserService.t:
+-------------------------------------------------------------------+
.............................................Selenium command success: $VAR1 = {
  'Params' => {},
  'Res' => {
    'command' => 'screenshot',
    'session_id' => '5a746826fe850fc08ec9b0594382af1d'
  },
  'Time' => 1692266544
};
 ok 46 - Saved screenshot in http://172.18.0.2/znuny-web/SeleniumScreenshots/1692266544-Selenium_Agent_Admin_AdminCustomerUserService.png

 not ok 47 - Error while executing command: clickElement: element not interactable
  (Session info: chrome=74.0.3729.169)
  (Driver info: chromedriver=74.0.3729.6 (255758eccf3d2444[91](https://github.com/tipue-dev/Znuny/actions/runs/5888904629/job/15972613271#step:6:92)b8a1317aa76e1ce10d57e9-refs/branch-heads/3729@{#29}),platform=Linux 5.15.0-[104](https://github.com/tipue-dev/Znuny/actions/runs/5888904629/job/15972613271#step:6:105)2-azure x86_64) at /__w/Znuny/Znuny/Kernel/cpan-lib/Selenium/Remote/Driver.pm line 412.

Selenium stack trace started at (eval 470) line 17
    Selenium::Remote::WebElement::_execute_command at /__w/Znuny/Znuny/Kernel/cpan-lib/Selenium/Remote/WebElement.pm line 63
    Selenium::Remote::WebElement::click at (eval 456) line 140
    Kernel::System::UnitTest::Selenium::RunTest at (eval 456) line 210
    eval '{...}' at /__w/Znuny/Znuny/Kernel/System/UnitTest/Driver.pm line 143
    Kernel::System::UnitTest::Driver::Run at /__w/Znuny/Znuny/Kernel/System/UnitTest.pm line 376

....
/opt/znuny/scripts/test/Selenium/Agent/Admin/AdminCustomerUserService.t ran 51 test(s) in 3.553s.

The Selector to find the element with the service id 1 is "every <input value="1">". There are multiple input fields that match this selector and are not clickable. The new selector finds the correct field. This is an issue since the service creation for the ITSM module has been removed from the test, otherwise the service id would be 2 and there would only be one match.

1 - 🐞 bug 🐞

Checklist