[GenericInterface] 2FA was added

CallMeFlanby commented 9 months ago

Proposed change

Added 2FA to the generic interface, allowing (but not forcing) by default the use of 2FA. Currently, if an account has 2FA activated, this cannot be used with the REST API. Not breaking change as users, that don't have 2FA will not be affected by this change.

Type of change

'1 - 🚀 feature' - New feature (which adds functionality to an existing integration)

Checklist

[x] The code change is tested and works locally.(❗)
[x] There is no commented out code in this PR.(❕)
[ ] You improved or added new unit tests.(❕)
[ ] Local ZnunyCodePolicy passed.(❕)
[ ] Local UnitTests / Selenium passed.(❕)
[ ] GitHub workflow CI (UnitTests / Selenium) passed.(❗)

CallMeFlanby commented 9 months ago

Found issue https://github.com/znuny/Znuny/issues/437 related to this.

rkaldung commented 8 months ago

@CallMeFlanby I like this idea, but it should also work with the optional usage of HTTP headers. See https://github.com/znuny/Znuny/blob/dev/Kernel/GenericInterface/Transport/HTTP/REST.pm#L231

Can you add this to?

CallMeFlanby commented 8 months ago

@CallMeFlanby I like this idea, but it should also work with the optional usage of HTTP headers. See https://github.com/znuny/Znuny/blob/dev/Kernel/GenericInterface/Transport/HTTP/REST.pm#L231

Can you add this to?

I hope it was correct. Somehow however I had to create a new pull request after I changed the name of my branch. Please check #502 now.

znuny / Znuny