znuny / Znuny

Znuny/Znuny LTS is a fork of the ((OTRS)) Community Edition, one of the most flexible web-based ticketing systems used for Customer Service, Help Desk, IT Service Management.
https://www.znuny.org
GNU General Public License v3.0
332 stars 82 forks source link

Bug - Overall extremely slow load times with ckeditor 4.22.1 included in Znuny 6.5.5 #533

Closed meisterheister closed 3 months ago

meisterheister commented 5 months ago

Environment

Expected behavior

After updating from Znuny 6.5.4 to 6.5.5 the newer ckeditor 4.22.1 does not affect system performance.

Actual behavior

Overall System performace is very slow. Ckeditor and plugins are causing the issue according to the web browser dev tools.

How to reproduce

Steps to reproduce the behavior:

  1. Setup Znuny 6.5.5. and add the old ckeditor 4.17.1 from Znuny release 6.5.4 to var/httpd/htdocs/js/thirdparty
  2. Browse to /index.pl?Action=AgentTicketPhone and wait till loading is complete. Notice also general slow load time e.g. on the Dashboard. The main menu is taking time to be shown.
  3. Now alter the system configuration to use the older ckeditor in Frontend::RichText::Path, Loader::Agent::CommonJS###100-CKEditor, Loader::Customer::CommonJS###100-CKEditor.
  4. Load times are good again.

Additional information

Screenshots

ckeditor 4.17.1

ckeditor4 17 1

ckeditor 4.22.1

ckeditor4 22 1
hanneshal commented 5 months ago

Hi @meisterheister,

thanks for the report. We appreciate it. we can reproduce this behaviour and in fact are working on this. The files should be bundled and minified, but they aren't.

One thing to note: you should check your webserver config. Those load times are way to high: Sample for a regular hosted instance.

image

Load time with disabled cache is 1.5 sec on version 6.5.5 (release) - even with this bug. Thats why it was not caught by the CI.

We get back when it is fixed.

Johannes

jepf commented 5 months ago

Internal issue 809.

meisterheister commented 5 months ago

Hi @meisterheister,

thanks for the report. We appreciate it. we can reproduce this behaviour and in fact are working on this. The files should be bundled and minified, but they aren't.

One thing to note: you should check your webserver config. Those load times are way to high: Sample for a regular hosted instance.

image

Load time with disabled cache is 1.5 sec on version 6.5.5 (release) - even with this bug. Thats why it was not caught by the CI.

We get back when it is fixed.

Johannes

Hi Johannes, thanks for the clarification! I have disabled Loader::Enabled::JS setting in sysconfig when capturing web browser logs but as you say it's not getting minified and there is no load time difference even if I have enabled the setting. As you can see in the screenshots it's much faster with ckeditor 4.17.1 and I really only change the editor so normally it's a good performance overall.

Regards Rick

hrobayo commented 5 months ago

Hi @meisterheister , following you workarround, usign CKEditor 6.17.1 and updating Frontend::RichText::Path, Loader::Agent::CommonJS###100-CKEditor, Loader::Customer::CommonJS###100-CKEditor , and finnaly replacing Core.UI.RichTextEditor.js with version from 6.5.4, load times are better, but with Loader::Enabled::JS enabled, shows javascript errors. , image

image

The errors are shown in both Agent and Customer Interfaces, is there another change I missing,

Thanks in advance for your help.

UPDATE

The error was due a custom skin, the property Frontend::RichText::Path change in recent versions, I have the old one Frontend::RichTextPath.

Problem solved, thanks for the hint.

Regards, Hugo

rkaldung commented 3 months ago

This is fixed with the release of Znuny LTS 6.5.6 and Znuny 7.0.15