Open LuBroering opened 5 months ago
Hi @LuBroering,
thanks a lot for your contribution. Currently is the Znuny Code Policy failing for your pr. Please check and verify your code again.
Thanks, Niklas
Hello @NiklasSchmitt , as far as I can see it is failing as the unchanged parts of the code aren't up to the Znuny Code Policy, or am I missing something?
I'm sorry, but sometimes our code policy is a bit ... fussy ...
$ git codePolicy Kernel/Modules/AgentTicketBulk.pm
================================================================================
Code policy context: Framework
Vendor: Znuny GmbH
Product name: Znuny
================================================================================
Using up to 6 parallel processes.
Kernel/Modules/AgentTicketBulk.pm
[File was tidied]
[Warning] ...
...
================================================================================
Summary
================================================================================
[Warning] (1)
(4) Kernel/Modules/AgentTicketBulk.pm
[Tidied] (1)
Kernel/Modules/AgentTicketBulk.pm
================================================================================
1 of 1 files were tidied or have warnings/errors.
diff:
$ git diff
diff --git a/Kernel/Modules/AgentTicketBulk.pm b/Kernel/Modules/AgentTicketBulk.pm
index 5e3a43aed5..c2096d28df 100644
--- a/Kernel/Modules/AgentTicketBulk.pm
+++ b/Kernel/Modules/AgentTicketBulk.pm
@@ -1325,7 +1325,7 @@ sub Run {
# only create one Article and time for merging
# add note
- if ( $MainTicketID ) {
+ if ($MainTicketID) {
my $ArticleID;
if (
$GetParam{'Subject'}
@NiklasSchmitt my bad didn't see that. Updated it
Proposed change
Creating only one article on ticket merge with AgentTicketBulk. This will resolve the Problem of having one article per merged ticket.
Checklist