Suggestions / Improvements: Dark Skin

[kersten-lohmeyer]

• Server OS: Debian 12
• Browser: Chrome (most current version)
• Znuny version: 7.1.2

First of all, thanks for a dark skin, now looking forward to a slim(mer) skin in dark and also light.

The gravatar colors are inverted in the dark skin. I think this is not intended:

Also when you are on a page which is long enough for the scrollbar to appear, then there's this white line next to the scrollbar which I'm not entirely sure if it is intended (but I think it would look better without it, but that's just me):

Also how do I return to the light theme? I can't uncheck the dark theme in user preferences? Can I undo this in the DB somehow? I don't think so since it's BLOB.

And this color combination is really awkward. I think you should display the badges in the same orange color like in the navigation:

[hanneshal]

Hi @kersten-lohmeyer

I'm able to switch between default and dark without a problem.

We will address the problem with the avatar and the suggestion regarding the badge colors in the next release.

Thanks for the feedback.

[kersten-lohmeyer]

Thanks. I cleared browser cache und restarted but I still don't have a "Default" theme option. How could I possibly fix this? Before the update to 7.1.12 there was nothing to choose in this dropdown. Nothing preselected, just empty.

Also when logged in with another user who has not selected "Dark" it looks like this:

Dark is preselected since being the only option. If I save it gets applied but can't go back.

[hanneshal]

Hi,

there should be a registration for the default skin:

Also the sysconfig Loader::Agent::DefaultSelectedSkin should be like this:

I updated the colors as suggested.

[kersten-lohmeyer]

That worked! Thanks a lot! Also for changing the colors. Did you also change the badge colors in the default skin?

[hanneshal]

That worked! Thanks a lot! Also for changing the colors. Did you also change the badge colors in the default skin?

Hi, cool. No I just changed it in the dark skin.

Edit: If you like, you can modify the following file - until the next release is there: var/httpd/htdocs/skins/Agent/dark/css/Core.Default.css

  .Avatar{
     filter: invert(180%) hue-rotate(180deg);
}
    .toolbar-row-wrapper .toolbar-row ul li a .iconWrapper span.Counter {
      background: var(--primary-color);
   }

[kersten-lohmeyer]

Would be really nice if it was the same color in the default skin. To be honest, I only noticed this in the dark skin. But now I can't unsee it in the default skin. Can you please change it there too?

[hanneshal]

Would be really nice if it was the same color in the default skin. To be honest, I only noticed this in the dark skin. But now I can't unsee it in the default skin. Can you please change it there too?

We will discuss it in the team. Actually I like the read color. But it will be discussed

[kersten-lohmeyer]

And the white line? Is that intentional? Maybe to make the scrollbar more visible? Also thanks for the temporary fix of the gravatar.

[kersten-lohmeyer]

The gravatar CSS did not fix it for me. I cleared Znuny and also browser cache. But that's not that important.

EDIT: Needs to be:

.UserAvatar{ filter: invert(180%) hue-rotate(180deg); }

But then the Popup has light color:

[hanneshal]

At the moment I can not tell where the white bar is coming from. This may take a while.

You change is correct, there is also another rule for the preferences. But this is ok for now.

    .UserAvatar img,
    .Avatar img{
       filter: invert(180%) hue-rotate(180deg);
    }

[kersten-lohmeyer]

At the moment I can not tell where the white bar is coming from. This may take a while.

You change is correct, there is also another rule for the preferences. But this is ok for now.

    .UserAvatar img,
    .Avatar img{
       filter: invert(180%) hue-rotate(180deg);
    }

Ok, perfect now. Thank you.

[dennykorsukewitz]

internal MR !1348

[dennykorsukewitz]

Fixed https://github.com/znuny/Znuny/commit/4ada84014f4127636e75e06ffbbc9674bdb18209

[dennykorsukewitz]

@hanneshal https://github.com/znuny/Znuny/commit/4ada84014f4127636e75e06ffbbc9674bdb18209#commitcomment-144703302

internal MR !1365

Commit: https://github.com/znuny/Znuny/commit/514dd9c1b3737f14b2dae5d7c58a6770ae7a128d