znuny / Znuny

Znuny/Znuny LTS is a fork of the ((OTRS)) Community Edition, one of the most flexible web-based ticketing systems used for Customer Service, Help Desk, IT Service Management.
https://www.znuny.org
GNU General Public License v3.0
381 stars 89 forks source link

Bug - Regression: "From" and "To" can not be expanded if an article is loaded after opening TIcketZoom #605

Open olifre opened 2 weeks ago

olifre commented 2 weeks ago

Environment

Expected behavior

Clicking on "From" and "To" in an article should expand the full mail address, i.e.:

John Doe

should be expanded to:

John Doe <john.doe@example.com>

(and unexpanded again when clicking again).

Actual behavior

This works if a ticket is visited directly, i.e.: https://someserver.example.com/znuny/index.pl?Action=AgentTicketZoom;TicketID=1234 but fails either if:

How to reproduce

Steps to reproduce the behavior:

  1. Visit any ticket which has some name and mail address in From / To.
  2. Click on "From" or "To".
  3. Observe it is expanded.
  4. Visit the ticket via an article URL or click on an article to load it.
  5. Observe it is not expandable anymore.

Additional information

This is a regression caused by: https://github.com/znuny/Znuny/commit/4f3baef3323b510ea012d0d6f290f579bc65449e which adapted the template to use div instead of p, but only adapted the javascript code in: https://github.com/znuny/Znuny/blob/86309bb873dca6bbcb789d9e8a50ad63be8cdc1d/var/httpd/htdocs/js/Core.Agent.TicketZoom.js#L787-L790 (i.e. Init of Core.Agent.TicketZoom), but not in: https://github.com/znuny/Znuny/blob/86309bb873dca6bbcb789d9e8a50ad63be8cdc1d/var/httpd/htdocs/js/Core.Agent.TicketZoom.js#L213-L216 (i.e. LoadArticle of Core.Agent.TicketZoom).

Adapting the second location should fix the problem :wink: .

dignin commented 1 day ago

Internal Issue# 991