znuny / Znuny4OTRS-AttachmentMultiUpload

This package adds the functionality to upload multiple attachments at once when using a modern HTML5 browser.
http://www.znuny.com/add-ons
3 stars 2 forks source link

Broken in AgentTicketNote view #2

Closed thorsteneckel closed 10 years ago

thorsteneckel commented 10 years ago

Depending on the Perl version and/or used OTRS packages the regular expression breakes the upload HTML like this:

<input name="FileUpload" id="FileUpload" type="file" size="30" / multiple="multiple">

The '/' should be after the 'multiple' attribute, at the end of the tag.

thorsteneckel commented 10 years ago

Fixed with commit: https://github.com/znuny/Znuny4OTRS-AttachmentMultiUpload/commit/bbbd81b0ff99163a6948ceab4345f1fcc0eaf63b

thorsteneckel commented 10 years ago

The issue still exists in combination with the Package 'KIX4OTRS'. This can be fixed by editing the following line in the files:

KIX4OTRSITSMIncidentProblem/Kernel/Modules/AgentTicketActionCommon.pm KIX4OTRSITSMIncidentProblem/Kernel/Modules/AgentTicketZoomTabActionCommon.pm

Search for:

# KIX4OTRS-capeIT
if ( $UploadStuff{Filename} ) {

replace with:

# KIX4OTRS-capeIT
if ( $UploadStuff{Filename} || $UploadStuff{Multiple} ) {

After that the package will work as designed.

ReneBoehm commented 10 years ago

This will be fixed in the next bugfix releases of KIX4OTRS.

thorsteneckel commented 10 years ago

+1 thanks!