search

znuny / Znuny4OTRS-SortByLastContact

Sort QueueView, StatusView and LockedView in OTRS by last contact.
https://www.znuny.com/add-ons/sort-by-last-contact
7 stars 2 forks source link

Uninstall leftover #8

Closed rkaldung closed 8 years ago

rkaldung commented 8 years ago

image

After uninstalling the addon it is not possible to remove the dynamic fields which are created during installation. Is it possible to remove the internal flag of the dynamic field when on uninstall?

thorsteneckel commented 8 years ago

Hi @hypericum - please have a look at this. Thanks!

hypericum commented 8 years ago

@rkaldung unfortunately DynamicFieldUpdate (Framwork function for changing DynamicFields) can't change the internal flag.

Solution is to create the dynamic fields as non-internal fields. Code has been updated, demo can be found on vz690. Please QA and if ok trigger me for a new version or build it by yourself. thx

rkaldung commented 8 years ago

Since the data stored in the dynamic field can be restored by running the bin scripts I recommend removing the data on uninstall, maybe with a little hint. Don't setting the field internal could lead to more problems when a user still remove the dynamic field. @thorsteneckel Do you agree?

thorsteneckel commented 8 years ago

I totally agree wir @rkaldung . After uninstalling the package the stored data is useless since it's inconsistent and misleading after the first incoming customer contact. We should remove it. Please do so @hypericum and switch to Code* blocks in the SOPM as written in the new issue https://github.com/znuny/Znuny4OTRS-SortByLastContact/issues/9 I created.