search

znuny / Znuny4OTRS-SortByLastContact

Sort QueueView, StatusView and LockedView in OTRS by last contact.
https://www.znuny.com/add-ons/sort-by-last-contact
7 stars 2 forks source link

Use Znuny4OTRS-Repo helper instead of packagesetup #9

Closed thorsteneckel closed 8 years ago

thorsteneckel commented 8 years ago

Currently the file 'var/packagesetup/Znuny4OTRSSortByLastContact.pm' is used to create the dynamic fields. This is should always be done via the Znuny4OTRS-Repo Helper in a SOPM CodeInstall block, if no special handling is needed.

While switching to the SOPM block another block 'CodeUninstall' should be added to remove the dynamic fields and their content on uninstall.

This issue was created due the discussion of https://github.com/znuny/Znuny4OTRS-SortByLastContact/issues/8

dennykorsukewitz commented 8 years ago

@hypericum please QA this commit: https://github.com/znuny/Znuny4OTRS-SortByLastContact/commit/571ec87dfca6640e76a5e3bcf31a5c1568f57014

dennykorsukewitz commented 8 years ago

@hypericum @thorsteneckel Hi guys, this issues is actually finished.

Could you take a look, please?

Thanks you 😄

thorsteneckel commented 8 years ago

I gave my thumb up to it: https://github.com/znuny/Znuny4OTRS-SortByLastContact/commit/571ec87dfca6640e76a5e3bcf31a5c1568f57014#commitcomment-17680878

hypericum commented 8 years ago

fine 4 me too

dennykorsukewitz commented 8 years ago

++ Thank you