znuny / znuny-feature-requests

This repository tracks feature requests as issues.
7 stars 1 forks source link

Use fullname for user mention label #51

Closed tgurr closed 2 months ago

tgurr commented 1 year ago

Followup of https://github.com/znuny/Znuny/pull/436 as requested by https://github.com/znuny/Znuny/pull/436#issuecomment-1556982580 though I'd rather consider this an actual fix to an existing problem rather than a real request for a feature. Anyways as I was unable to solve this myself as it's not enough to just change the variable either in the code directly (see my failed attempt at https://github.com/znuny/Znuny/pull/436) or via sysconfig as it'll result in:

Proposed change

Change the displayed username to fullname to be more useful and to bring it in line with what is shown in the mentions widget.

For example in our company the username can be quite meaningless/cryptic so if you mention multiple persons like:

@user1 check network @user2 check firewall

it would end up being problematic to identify which person is actually meant as it would result in something like:

image

While with changing it to fullname it'll read:

image

which also brings it in line with the mentions shown in the mentions widget where fullname is already being used:

image

rkaldung commented 4 months ago

The full name will be defined by the value of the system configuration FirstnameLastnameOrder.

rkaldung commented 4 months ago

Internal issue 863

rkaldung commented 2 months ago

@tgurr This feature will be released with Znuny 7.1.1

tgurr commented 2 months ago

@rkaldung thanks! Any chance this will get backported to 6.5 LTS?

rkaldung commented 2 months ago

@tgurr I'm sorry, but this has not been planned. Maybe it's worth a try to check the commit if you really need this and add the changed to your Custom/ folder.