search

znxlwm / pytorch-generative-model-collections

Collection of generative models in Pytorch version.
2.59k stars 546 forks source link

Missed a colon in InfoGAN code #8

Open back2yes opened 6 years ago

back2yes commented 6 years ago

Great job. By the way, I found this line of code doubtful:

https://github.com/znxlwm/pytorch-generative-model-collections/blob/5207b2fda3a9832c182e27dbbf2658b3078021ef/infoGAN.py#L78

Maybe this line should be changed into: a = F.sigmoid(x[:, : self.output_dim])

jmmcd commented 6 years ago

Agreed - just spotted your issue after making this fix in a pull request.