zo0r / react-native-conekta

React Native Conekta SDK for iOS and Android
https://www.conekta.io
MIT License
32 stars 22 forks source link

Support for React Native 0.56 #8

Open andidev opened 6 years ago

andidev commented 6 years ago

I'm getting the following with react-native 0.56.0

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':app'.
> Could not resolve all dependencies for configuration ':app:_debugApk'.
   > A problem occurred configuring project ':react-native-conekta'.
      > The SDK Build Tools revision (23.0.1) is too low for project ':react-native-conekta'. Minimum required is 25.0.0

https://github.com/zo0r/react-native-conekta/blob/b5d7f727028ea0475543acca3ee7245b003f0ed8/android/build.gradle#L4-L5

Should be updated to

    compileSdkVersion 25
    buildToolsVersion "25.0.2"
    targetSdkVersion 25

or even better values from the root project

    compileSdkVersion rootProject.hasProperty('compileSdkVersion') ? rootProject.compileSdkVersion : 25
    buildToolsVersion rootProject.hasProperty('buildToolsVersion') ? rootProject.buildToolsVersion : "25.0.2"
        targetSdkVersion rootProject.hasProperty('targetSdkVersion') ? rootProject.targetSdkVersion : 25