search

zobeirhamid / react-native-scrollable-navigation-bar

Respecting navigation bar for scrolling screens.
https://zobeirhamid.github.io/react-native-scrollable-navigation-bar/
MIT License
266 stars 29 forks source link

Add props to NavigationBarIcon #17

Closed hirbod closed 4 years ago

hirbod commented 4 years ago

https://github.com/zobeirhamid/react-native-scrollable-navigation-bar/blob/master/src/components/NavigationBar/NavigationBarIcon.js#L16

So we could pass a hitSlop for example

zobeirhamid commented 4 years ago

@Hirbod First, I want to thank you for all your contributions, they are highly appreciated. Next, I agree one should be able to pass Props to the Touchable Component, but I would rather prefer to be able to specify a TouchableComponent to have even greater control.

hirbod commented 4 years ago

You're welcome. Thanks for this amazing Component. And yeah, that is a good idea!

zobeirhamid commented 4 years ago

Fixed.